components/autofill/core/browser/autofill_type.cc - Issue 1863533003: Sending a vote that a Password form looks like a SignUp form.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_type.cc

Issue 1863533003: Sending a vote that a Password form looks like a SignUp form. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc ('k') | components/autofill/core/browser/field_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_type.cc

diff --git a/components/autofill/core/browser/autofill_type.cc b/components/autofill/core/browser/autofill_type.cc

index d75ef411f574e18585b4fc9a2588dc7133147cc5..b5567b257bf8cc9f607536d9ca43a17b0203ba4d 100644

--- a/components/autofill/core/browser/autofill_type.cc

+++ b/components/autofill/core/browser/autofill_type.cc

@@ -125,6 +125,7 @@ FieldTypeGroup AutofillType::group() const {

case NEW_PASSWORD:

case PROBABLY_NEW_PASSWORD:

case NOT_NEW_PASSWORD:

+ case PROBABLY_ACCOUNT_CREATION_PASSWORD:

return PASSWORD_FIELD;

case NO_SERVER_DATA:

@@ -655,6 +656,8 @@ std::string AutofillType::ToString() const {

return "PROBABLY_NEW_PASSWORD";

case NOT_NEW_PASSWORD:

return "NOT_NEW_PASSWORD";

+ case PROBABLY_ACCOUNT_CREATION_PASSWORD:

+ return "PROBABLY_ACCOUNT_CREATION_PASSWORD";

case MAX_VALID_FIELD_TYPE:

return std::string();