Sending a vote that a Password form looks like a SignUp form.

components/autofill/content/renderer/password_form_conversion_utils.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_form_conversion_utils.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
@@ skipping 371 matching lines @@
   // fields. If there is a visible username before visible password, then ignore
   // invisible username fields.
   // If there is no visible password field, don't ignore any elements (i.e. use
   // the latest username field just before selected password field).
   bool ignore_invisible_passwords = false;
   bool ignore_invisible_usernames = false;
   FoundVisiblePasswordAndVisibleUsernameBeforePassword(
       form, &ignore_invisible_passwords, &ignore_invisible_usernames);
   std::string layout_sequence;
   layout_sequence.reserve(form.control_elements.size());
+  size_t number_of_non_empty_text_non_password_fields = 0;
   for (size_t i = 0; i < form.control_elements.size(); ++i) {
     WebFormControlElement control_element = form.control_elements[i];
 
     WebInputElement* input_element = toWebInputElement(&control_element);
     if (!input_element || !input_element->isEnabled())
       continue;
 
     bool element_is_invisible = !form_util::IsWebNodeVisible(*input_element);
     if (input_element->isTextField()) {
       if (input_element->isPasswordField()) {
         if (element_is_invisible && ignore_invisible_passwords)
           continue;
         layout_sequence.push_back('P');
       } else {
+        if (nonscript_modified_values &&
+            nonscript_modified_values->find(*input_element) !=
+                nonscript_modified_values->end())
+          ++number_of_non_empty_text_non_password_fields;
         if (element_is_invisible && ignore_invisible_usernames)
           continue;
         layout_sequence.push_back('N');
       }
     }
 
     bool password_marked_by_autocomplete_attribute =
         HasAutocompleteAttributeValue(*input_element,
                                       kAutocompleteCurrentPassword) ||
         HasAutocompleteAttributeValue(*input_element, kAutocompleteNewPassword);
@@ skipping 171 matching lines @@
         "PasswordManager.EmptyUsernames.PasswordFieldCount",
         std::count(layout_sequence.begin(), layout_sequence.end(), 'P'));
   }
 
   password_form->scheme = PasswordForm::SCHEME_HTML;
   password_form->ssl_valid = false;
   password_form->preferred = false;
   password_form->blacklisted_by_user = false;
   password_form->type = PasswordForm::TYPE_MANUAL;
 
+  // The password form is considered that it looks like SignUp form if it has
+  // more than 1 text fields with user input or it has a new password field and

[vabr (Chromium), 2016/04/06 01:31:57]

nit: fields -> field

[dvadym, 2016/04/06 16:02:20]

Done.

+  // no password field.

[vabr (Chromium), 2016/04/06 01:31:57]

nit: password field -> current password field
(To avoid confusion of "password field" with any <input type=password>.)

[dvadym, 2016/04/06 16:02:20]

Done.

+  password_form->does_look_like_signup_form =
+      number_of_non_empty_text_non_password_fields > 1 ||
+      (number_of_non_empty_text_non_password_fields == 1 &&
+       password_form->password_element.empty() &&
+       !password_form->new_password_element.empty());
   return true;
 }
 
 }  // namespace
 
 bool IsGaiaReauthenticationForm(
     const GURL& origin,
     const std::vector<blink::WebFormControlElement>& control_elements) {
   if (origin != GaiaUrls::GetInstance()->gaia_url().GetOrigin())
     return false;
@@ skipping 79 matching lines @@
 }
 
 bool HasAutocompleteAttributeValue(const blink::WebInputElement& element,
                                    const char* value_in_lowercase) {
   return base::LowerCaseEqualsASCII(
       base::StringPiece16(element.getAttribute("autocomplete")),
       value_in_lowercase);
 }
 
 }  // namespace autofill