Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: components/autofill/core/common/password_form.h

Issue 1863533003: Sending a vote that a Password form looks like a SignUp form. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment fix Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__ 5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
6 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__ 6 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 // If true, this form was parsed using Autofill predictions. 267 // If true, this form was parsed using Autofill predictions.
268 bool was_parsed_using_autofill_predictions; 268 bool was_parsed_using_autofill_predictions;
269 269
270 // If true, this match was found using public suffix matching. 270 // If true, this match was found using public suffix matching.
271 bool is_public_suffix_match; 271 bool is_public_suffix_match;
272 272
273 // If true, this is a credential saved through an Android application, and 273 // If true, this is a credential saved through an Android application, and
274 // found using affiliation-based match. 274 // found using affiliation-based match.
275 bool is_affiliation_based_match; 275 bool is_affiliation_based_match;
276 276
277 // If true, this form looks like SignUp form according to local heuristics.
278 bool does_look_like_signup_form;
279
277 // Return true if we consider this form to be a change password form. 280 // Return true if we consider this form to be a change password form.
278 // We use only client heuristics, so it could include signup forms. 281 // We use only client heuristics, so it could include signup forms.
279 bool IsPossibleChangePasswordForm() const; 282 bool IsPossibleChangePasswordForm() const;
280 283
281 // Return true if we consider this form to be a change password form 284 // Return true if we consider this form to be a change password form
282 // without username field. We use only client heuristics, so it could 285 // without username field. We use only client heuristics, so it could
283 // include signup forms. 286 // include signup forms.
284 bool IsPossibleChangePasswordFormWithoutUsername() const; 287 bool IsPossibleChangePasswordFormWithoutUsername() const;
285 288
286 // Equality operators for testing. 289 // Equality operators for testing.
(...skipping 22 matching lines...) Expand all
309 using ConstPasswordFormMap = std::map<base::string16, const PasswordForm*>; 312 using ConstPasswordFormMap = std::map<base::string16, const PasswordForm*>;
310 313
311 // For testing. 314 // For testing.
312 std::ostream& operator<<(std::ostream& os, PasswordForm::Layout layout); 315 std::ostream& operator<<(std::ostream& os, PasswordForm::Layout layout);
313 std::ostream& operator<<(std::ostream& os, const PasswordForm& form); 316 std::ostream& operator<<(std::ostream& os, const PasswordForm& form);
314 std::ostream& operator<<(std::ostream& os, PasswordForm* form); 317 std::ostream& operator<<(std::ostream& os, PasswordForm* form);
315 318
316 } // namespace autofill 319 } // namespace autofill
317 320
318 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__ 321 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
OLDNEW
« no previous file with comments | « components/autofill/core/browser/field_types.h ('k') | components/autofill/core/common/password_form.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698