components/mus/ws/focus_controller.cc - Issue 1863523006: mash: Make system tray bubble close when another window is activated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/ws/focus_controller.cc

Issue 1863523006: mash: Make system tray bubble close when another window is activated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/mus/ws/focus_controller.cc

diff --git a/components/mus/ws/focus_controller.cc b/components/mus/ws/focus_controller.cc

index 6985893b814fd69b3e695d605bc1e3c5e297c64f..9a79fd7c0f6bf8124376da3442501af6292dc84f 100644

--- a/components/mus/ws/focus_controller.cc

+++ b/components/mus/ws/focus_controller.cc

@@ -75,6 +75,8 @@ void FocusController::SetFocusedWindow(ServerWindow* window) {

if (GetFocusedWindow() == window)

return;

+ // TODO(jamescook): Failures to set focus should be propagated back to the

sky 2016/04/07 17:55:10 Nuke this TODO. I have a patch out to fix.

James Cook 2016/04/07 20:43:43 Done.

+ // client so it doesn't get out of sync. http://crbug.com/600869

SetFocusedWindowImpl(FocusControllerChangeSource::EXPLICIT, window);

}

« no previous file with comments | « ash/mus/sysui_application.cc ('k') | mash/wm/public/interfaces/container.mojom » ('j') | mash/wm/public/interfaces/container.mojom » ('J')