base/bit_cast.h - Issue 1863523005: fix incorrect libstdc++ from GCC >= 5.1 check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/bit_cast.h

Issue 1863523005: fix incorrect libstdc++ from GCC >= 5.1 check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ios builds Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/bit_cast.h

diff --git a/base/bit_cast.h b/base/bit_cast.h

index ad38238beb5c08902691dc3a9c8a67784714595c..853e86589e9eeca8d6f1634607e9d00e16071ee5 100644

--- a/base/bit_cast.h

+++ b/base/bit_cast.h

@@ -64,7 +64,7 @@ inline Dest bit_cast(const Source& source) {

static_assert(sizeof(Dest) == sizeof(Source),

"bit_cast requires source and destination to be the same size");

-#if ((defined(__GLIBCXX__) && (__GLIBCXX__ >= 20150422)) || \

+#if (__GNUC__ > 5 || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1) || \

defined(_LIBCPP_VERSION))

// GCC 5.1 contains the first libstdc++ with is_trivially_copyable.

// Assume libc++ Just Works: is_trivially_copyable added on May 13th 2011.

« no previous file with comments | « no previous file | no next file » | no next file with comments »