Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1863513002: Mac: Remove some remaining 10.6 logic for absent overlay scrollbar APIs (Closed)

Created:
4 years, 8 months ago by tapted
Modified:
4 years, 8 months ago
Reviewers:
Avi (use Gerrit), Nico
CC:
chromium-reviews, blink-reviews, darin-cc_chromium.org, kinuko+watch, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Remove some remaining 10.6 logic for absent overlay scrollbar APIs Follow-up to r379346 and r384946 to catch some remaining NSScroller stuff not needed since moving on from SnowLeopard. BUG=579255 Committed: https://crrev.com/3c16cebb250e838b0254577952c2f82ed649a57e Cr-Commit-Position: refs/heads/master@{#385363}

Patch Set 1 #

Total comments: 5

Patch Set 2 : lint headers #

Patch Set 3 : Zap notification, import appkit rather than forward decs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -53 lines) Patch
M base/mac/sdk_forward_declarations.h View 2 chunks +0 lines, -6 lines 0 comments Download
M base/mac/sdk_forward_declarations.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/theme_helper_mac.mm View 1 3 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/NSScrollerImpDetails.h View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M ui/base/test/scoped_preferred_scroller_style_mac.mm View 1 2 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
tapted
Hi Nico/avi, please take a look avi: theme_helper_mac.mm thakis: everything else https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm File third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm (right): ...
4 years, 8 months ago (2016-04-05 09:06:02 UTC) #5
Avi (use Gerrit)
lgtm https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm File third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm (right): https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm#newcode225 third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm:225: postNotificationName:NSPreferredScrollerStyleDidChangeNotification On 2016/04/05 09:06:02, tapted wrote: > nothing ...
4 years, 8 months ago (2016-04-05 11:26:32 UTC) #6
Nico
https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm File third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm (right): https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm#newcode225 third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm:225: postNotificationName:NSPreferredScrollerStyleDidChangeNotification On 2016/04/05 09:06:02, tapted wrote: > nothing in ...
4 years, 8 months ago (2016-04-05 12:30:30 UTC) #7
tapted
https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm File third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm (right): https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm#newcode225 third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm:225: postNotificationName:NSPreferredScrollerStyleDidChangeNotification On 2016/04/05 12:30:30, Nico wrote: > On 2016/04/05 ...
4 years, 8 months ago (2016-04-05 12:35:17 UTC) #8
tapted
PTAL I also verified manually that scrollers behave properly in Blink when changing the pref ...
4 years, 8 months ago (2016-04-05 12:53:14 UTC) #9
Nico
are you synced past https://codereview.chromium.org/1847533004/ locally?
4 years, 8 months ago (2016-04-05 12:56:03 UTC) #10
tapted
On 2016/04/05 12:56:03, Nico wrote: > are you synced past https://codereview.chromium.org/1847533004/ locally? Ah, that would ...
4 years, 8 months ago (2016-04-05 12:58:13 UTC) #12
Nico
lgtm
4 years, 8 months ago (2016-04-05 13:36:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863513002/40001
4 years, 8 months ago (2016-04-06 00:45:45 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-06 01:27:15 UTC) #18
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 01:28:40 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3c16cebb250e838b0254577952c2f82ed649a57e
Cr-Commit-Position: refs/heads/master@{#385363}

Powered by Google App Engine
This is Rietveld 408576698