Mac: Remove some remaining 10.6 logic for absent overlay scrollbar APIs

Mac: Remove some remaining 10.6 logic for absent overlay scrollbar APIs

Follow-up to r379346 and r384946 to catch some remaining NSScroller
stuff not needed since moving on from SnowLeopard.

BUG=579255
Committed: https://crrev.com/3c16cebb250e838b0254577952c2f82ed649a57e
Cr-Commit-Position: refs/heads/master@{#385363}

[tapted, 2016-04-05 08:59:06]

Description was changed from

==========
Mac: Remove 10.6 logic for absent overlay scrollbar APIs

BUG=579255
==========

to

==========
Mac: Remove 10.6 logic for absent overlay scrollbar APIs

Follow-up to r379346 and r384946 to catch some remaining NSScroller
stuff not needed since moving on from SnowLeopard.

BUG=579255
==========

[tapted, 2016-04-05 08:59:06]

tapted@chromium.org changed reviewers:
+ thakis@chromium.org

[tapted, 2016-04-05 08:59:26]

Description was changed from

==========
Mac: Remove 10.6 logic for absent overlay scrollbar APIs

Follow-up to r379346 and r384946 to catch some remaining NSScroller
stuff not needed since moving on from SnowLeopard.

BUG=579255
==========

to

==========
Mac: Remove some remaining 10.6 logic for absent overlay scrollbar APIs

Follow-up to r379346 and r384946 to catch some remaining NSScroller
stuff not needed since moving on from SnowLeopard.

BUG=579255
==========

[tapted, 2016-04-05 09:06:01]

tapted@chromium.org changed reviewers:
+ avi@chromium.org

[tapted, 2016-04-05 09:06:02]

Hi Nico/avi, please take a look

avi: theme_helper_mac.mm	
thakis: everything else

https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm (right):

https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm:225:
postNotificationName:NSPreferredScrollerStyleDidChangeNotification
nothing in blink seems to listen for this - maybe it's safe to just delete..

[Avi (use Gerrit), 2016-04-05 11:26:32]

lgtm

https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm (right):

https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm:225:
postNotificationName:NSPreferredScrollerStyleDidChangeNotification
On 2016/04/05 09:06:02, tapted wrote:
> nothing in blink seems to listen for this - maybe it's safe to just delete..

delete away.

[Nico, 2016-04-05 12:30:30]

https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm (right):

https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm:225:
postNotificationName:NSPreferredScrollerStyleDidChangeNotification
On 2016/04/05 09:06:02, tapted wrote:
> nothing in blink seems to listen for this - maybe it's safe to just delete..

Does chrome do the right thing if you change the preferred scroller style in
sysprefs? (it used to, maybe someone broke that?)

[tapted, 2016-04-05 12:35:17]

https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm (right):

https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm:225:
postNotificationName:NSPreferredScrollerStyleDidChangeNotification
On 2016/04/05 12:30:30, Nico wrote:
> On 2016/04/05 09:06:02, tapted wrote:
> > nothing in blink seems to listen for this - maybe it's safe to just delete..
> 
> Does chrome do the right thing if you change the preferred scroller style in
> sysprefs? (it used to, maybe someone broke that?)

Yup - the listener is at content/browser/theme_helper_mac.mm . That feeds
through a change from the browser process into blink, ending up in this method.
Currently, this method then re-broadcasts it, but nothing in blink's code is
subscribing to it.

[tapted, 2016-04-05 12:53:14]

PTAL

I also verified manually that scrollers behave properly in Blink when changing
the pref between Always Show Scrollbars and not, after removing the
notificaiton.

Also, strangely, my macbook didn't like the sdk_forward_declarations changes --
I was getting `error: 'NSPreferredScrollerStyleDidChangeNotification' is
partial: introduced in OS X 10.7`.

But for some reason I didn't get these on my macpro, nor in the try runs on
Patchset 1.

So I've rolled back those changes in case developer builds are affected
similarly. (the forward decs in NSScrollerImpDetails.h are fine since they were
unused before this CL).

https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm (right):

https://codereview.chromium.org/1863513002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm:225:
postNotificationName:NSPreferredScrollerStyleDidChangeNotification
On 2016/04/05 11:26:32, Avi wrote:
> On 2016/04/05 09:06:02, tapted wrote:
> > nothing in blink seems to listen for this - maybe it's safe to just delete..
> 
> delete away.

Done.

[Nico, 2016-04-05 12:56:03]

are you synced past https://codereview.chromium.org/1847533004/ locally?

[tapted, 2016-04-05 12:57:36]

Patchset #4 (id:60001) has been deleted

[tapted, 2016-04-05 12:58:13]

On 2016/04/05 12:56:03, Nico wrote:
> are you synced past https://codereview.chromium.org/1847533004/ locally?

Ah, that would be it :). **deletes patchset 4**

[Nico, 2016-04-05 13:36:00]

lgtm

[tapted, 2016-04-06 00:45:09]

The CQ bit was checked by tapted@chromium.org

[tapted, 2016-04-06 00:45:10]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1863513002/#ps40001
(title: "Zap notification, import appkit rather than forward decs")

[commit-bot: I haz the power, 2016-04-06 00:45:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1863513002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1863513002/40001

[commit-bot: I haz the power, 2016-04-06 01:27:14]

Description was changed from

==========
Mac: Remove some remaining 10.6 logic for absent overlay scrollbar APIs

Follow-up to r379346 and r384946 to catch some remaining NSScroller
stuff not needed since moving on from SnowLeopard.

BUG=579255
==========

to

==========
Mac: Remove some remaining 10.6 logic for absent overlay scrollbar APIs

Follow-up to r379346 and r384946 to catch some remaining NSScroller
stuff not needed since moving on from SnowLeopard.

BUG=579255
==========

[commit-bot: I haz the power, 2016-04-06 01:27:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-06 01:28:39]

Description was changed from

==========
Mac: Remove some remaining 10.6 logic for absent overlay scrollbar APIs

Follow-up to r379346 and r384946 to catch some remaining NSScroller
stuff not needed since moving on from SnowLeopard.

BUG=579255
==========

to

==========
Mac: Remove some remaining 10.6 logic for absent overlay scrollbar APIs

Follow-up to r379346 and r384946 to catch some remaining NSScroller
stuff not needed since moving on from SnowLeopard.

BUG=579255

Committed: https://crrev.com/3c16cebb250e838b0254577952c2f82ed649a57e
Cr-Commit-Position: refs/heads/master@{#385363}
==========

[commit-bot: I haz the power, 2016-04-06 01:28:40]

Patchset 3 (id:??) landed as
https://crrev.com/3c16cebb250e838b0254577952c2f82ed649a57e
Cr-Commit-Position: refs/heads/master@{#385363}