DescriptionReland "Add --serial-id option to host_forwarder."
This relands r209945.
r242846 slightly changed the CLI <-> device daemon message sequence which made
the following check fail in case the device daemon was started but already
running on the device: device_forwarder_main.cc:10: CHECK_GT(bytes_read, 0).
This was actually caused by an unexposed long standing issue in daemon.cc.
ConnectToUnixDomainSocket() is performing a hand check to make sure that the
CLI is connecting to the forwarder daemon. While doing this hand check, rather
than only reading the expected fixed-size message, the function was reading all
the available bytes in the socket thus consuming the client data.
BUG=242846
R=bulach@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210273
Patch Set 1 #Patch Set 2 : Original CL + fix #Patch Set 3 : #Patch Set 4 : Rebase #
Messages
Total messages: 6 (0 generated)
|