Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 18635005: Reland "Add --serial-id option to host_forwarder." (Closed)

Created:
7 years, 5 months ago by Philippe
Modified:
7 years, 5 months ago
Reviewers:
bulach, digit1
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Reland "Add --serial-id option to host_forwarder." This relands r209945. r242846 slightly changed the CLI <-> device daemon message sequence which made the following check fail in case the device daemon was started but already running on the device: device_forwarder_main.cc:10: CHECK_GT(bytes_read, 0). This was actually caused by an unexposed long standing issue in daemon.cc. ConnectToUnixDomainSocket() is performing a hand check to make sure that the CLI is connecting to the forwarder daemon. While doing this hand check, rather than only reading the expected fixed-size message, the function was reading all the available bytes in the socket thus consuming the client data. BUG=242846 R=bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210273

Patch Set 1 #

Patch Set 2 : Original CL + fix #

Patch Set 3 : #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -169 lines) Patch
M build/android/pylib/forwarder.py View 1 2 3 9 chunks +14 lines, -36 lines 0 comments Download
M tools/android/forwarder2/daemon.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/device_forwarder_main.cc View 6 chunks +20 lines, -48 lines 0 comments Download
M tools/android/forwarder2/host_forwarder_main.cc View 11 chunks +107 lines, -84 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Philippe
FYI, you can diff against patch set 1 to see the fix.
7 years, 5 months ago (2013-07-03 13:41:57 UTC) #1
bulach
lgtm, good catch! nit: please change the title to "Reland" :)
7 years, 5 months ago (2013-07-03 13:55:00 UTC) #2
Philippe
On 2013/07/03 13:55:00, bulach wrote: > lgtm, good catch! nit: please change the title to ...
7 years, 5 months ago (2013-07-03 14:01:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/18635005/21001
7 years, 5 months ago (2013-07-04 15:51:52 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-04 16:21:42 UTC) #5
Philippe
7 years, 5 months ago (2013-07-05 07:42:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r210273.

Powered by Google App Engine
This is Rietveld 408576698