Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 18635003: Reintroduce runtime zone to Isolate. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
Yang, danno
CC:
v8-dev
Visibility:
Public.

Description

Reintroduce runtime zone to Isolate. In case tcmalloc is not being used, the malloc()/free() overhead can be significant for several runtime functions like StringReplace. Therefore we reintroduce the runtime_zone into Isolate and reenable the segment caching functionality of Zone. There's now also a simpler version of ZoneScope w/o nesting capabilities. BUG=v8:2759 R=danno@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15465

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -28 lines) Patch
M src/isolate.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/runtime.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M src/zone.h View 4 chunks +27 lines, -2 lines 0 comments Download
M src/zone.cc View 1 chunk +64 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-07-03 10:32:17 UTC) #1
danno
lgtm
7 years, 5 months ago (2013-07-03 11:36:38 UTC) #2
Yang
On 2013/07/03 11:36:38, danno wrote: > lgtm lgtm
7 years, 5 months ago (2013-07-03 11:37:13 UTC) #3
Benedikt Meurer
7 years, 5 months ago (2013-07-03 11:40:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r15465 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698