Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1863483004: Plugin Power Saver: Update pixel test tolerance and error behavior. (Closed)

Created:
4 years, 8 months ago by tommycli
Modified:
4 years, 8 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Update pixel test tolerance and error behavior. 1. This increases the manhattan distance tolerance to 25 in BGR space. 2. This now reports all non-matching pixels instead of just the first. BUG=599484 Committed: https://crrev.com/3188721c5cb06cc130d1bd4206a11e9522bf969f Cr-Commit-Position: refs/heads/master@{#385302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863483004/1
4 years, 8 months ago (2016-04-05 21:00:53 UTC) #4
tommycli
maniscalco: PTAL, this is the 2nd attempt to fix the issue we discussed over IM.
4 years, 8 months ago (2016-04-05 21:00:54 UTC) #5
maniscalco
lgtm
4 years, 8 months ago (2016-04-05 21:33:40 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 22:06:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863483004/1
4 years, 8 months ago (2016-04-05 22:11:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 22:18:53 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 22:22:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3188721c5cb06cc130d1bd4206a11e9522bf969f
Cr-Commit-Position: refs/heads/master@{#385302}

Powered by Google App Engine
This is Rietveld 408576698