chrome/browser/ui/gtk/apps/native_app_window_gtk.h - Issue 186343002: Create windows for new app window bounds API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/apps/native_app_window_gtk.h

Issue 186343002: Create windows for new app window bounds API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nit Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/apps/native_app_window_gtk.h

diff --git a/chrome/browser/ui/gtk/apps/native_app_window_gtk.h b/chrome/browser/ui/gtk/apps/native_app_window_gtk.h

index 0ba3edbbcfcc867c4aa71005450e36a1933b4278..dca84746c14dcb927355d65305175df52902370c 100644

--- a/chrome/browser/ui/gtk/apps/native_app_window_gtk.h

+++ b/chrome/browser/ui/gtk/apps/native_app_window_gtk.h

@@ -87,10 +87,10 @@ class NativeAppWindowGtk : public apps::NativeAppWindow,

virtual void ShowWithApp() OVERRIDE;

virtual void UpdateShelfMenu() OVERRIDE;

// Calls gtk_window_set_geometry_hints with the current size constraints.

- virtual gfx::Size GetMinimumSize() const OVERRIDE;

- virtual void SetMinimumSize(const gfx::Size& size) OVERRIDE;

- virtual gfx::Size GetMaximumSize() const OVERRIDE;

- virtual void SetMaximumSize(const gfx::Size& size) OVERRIDE;

+ virtual gfx::Size GetContentMinimumSize() const OVERRIDE;

+ virtual void SetContentMinimumSize(const gfx::Size& size) OVERRIDE;

+ virtual gfx::Size GetContentMaximumSize() const OVERRIDE;

+ virtual void SetContentMaximumSize(const gfx::Size& size) OVERRIDE;

// web_modal::WebContentsModalDialogHost implementation.

virtual gfx::NativeView GetHostView() const OVERRIDE;

@@ -131,7 +131,7 @@ class NativeAppWindowGtk : public apps::NativeAppWindow,

void OnConfigureDebounced();

- void UpdateWindowMinMaxSize();

+ void UpdateContentMinMaxSize();

apps::AppWindow* app_window_; // weak - AppWindow owns NativeAppWindow.