chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 186343002: Create windows for new app window bounds API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 186343002: Create windows for new app window bounds API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nit Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index a809ab26aa00fccdb89c3b6f68186873db8c8b6a..0a1c36dd846386f34b3b8668723bf9eebd720505 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -525,7 +525,7 @@ bool WindowsCreateFunction::RunImpl() {

if (chrome::GetActiveDesktop() == chrome::HOST_DESKTOP_TYPE_ASH) {

AppWindow::CreateParams create_params;

create_params.window_type = AppWindow::WINDOW_TYPE_V1_PANEL;

- create_params.bounds = window_bounds;

+ create_params.window_spec.bounds = window_bounds;

create_params.focused = saw_focus_key && focused;

AppWindow* app_window = new AppWindow(

window_profile, new ChromeAppWindowDelegate(), GetExtension());