Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5844)

Unified Diff: chrome/browser/extensions/api/app_window/app_window_api.h

Issue 186343002: Create windows for new app window bounds API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nit Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/app_window/app_window_api.h
diff --git a/chrome/browser/extensions/api/app_window/app_window_api.h b/chrome/browser/extensions/api/app_window/app_window_api.h
index 28c358553623b48078944771ffcedb545c6393eb..1dbb1054b1900e8f01b8e853d581a0804fe5eaee 100644
--- a/chrome/browser/extensions/api/app_window/app_window_api.h
+++ b/chrome/browser/extensions/api/app_window/app_window_api.h
@@ -28,7 +28,10 @@ class AppWindowCreateFunction : public ChromeAsyncExtensionFunction {
virtual bool RunImpl() OVERRIDE;
private:
- bool inject_html_titlebar_;
+ bool GetBoundsSpec(
+ const extensions::api::app_window::CreateWindowOptions& options,
+ apps::AppWindow::CreateParams* params,
+ std::string* error);
apps::AppWindow::Frame GetFrameFromString(const std::string& frame_string);
bool GetFrameOptions(
@@ -36,6 +39,8 @@ class AppWindowCreateFunction : public ChromeAsyncExtensionFunction {
apps::AppWindow::CreateParams* create_params);
void UpdateFrameOptionsForChannel(
apps::AppWindow::CreateParams* create_params);
+
+ bool inject_html_titlebar_;
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698