Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1863413004: Rename Slot.getAssingedNodes() -> Slot.assignedNodes() (Closed)

Created:
4 years, 8 months ago by hayato
Modified:
4 years, 8 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Slot.getAssingedNodes() -> Slot.assignedNodes() The spec change is: https://github.com/w3c/webcomponents/commit/77edff3b3aff3fdaa5291fafc16d871832ac93ed BUG=601348 Committed: https://crrev.com/5be373033158c9c7b5ae3c8103352b45f5462b6e Cr-Commit-Position: refs/heads/master@{#385995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -131 lines) Patch
M third_party/WebKit/LayoutTests/shadow-dom/slotchange-event.html View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v1-default-slots.html View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-1.html View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-2.html View 1 chunk +15 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-dynamic.html View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-in-v0.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-with-closed-shadow-tree.html View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v1-slots-dom-mutation.html View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-1.html View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-2.html View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-3.html View 1 chunk +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-4.html View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v1-slots-in-document-tree.html View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v1-slots-text-nodes.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/ShadowDOM/v1-distribution.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/SlotScopedTraversal.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863413004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863413004/1
4 years, 8 months ago (2016-04-08 02:02:29 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-08 03:14:04 UTC) #4
hayato
PTAL
4 years, 8 months ago (2016-04-08 04:47:09 UTC) #6
kochi
lgtm
4 years, 8 months ago (2016-04-08 05:28:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863413004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863413004/1
4 years, 8 months ago (2016-04-08 05:32:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 05:38:04 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 05:39:42 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5be373033158c9c7b5ae3c8103352b45f5462b6e
Cr-Commit-Position: refs/heads/master@{#385995}

Powered by Google App Engine
This is Rietveld 408576698