Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1863413002: Correctly account for nested multicol top border / padding. (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly account for nested multicol top border / padding. Top border and padding will be baked into the first LayoutColumnSet object of a multicol container, but not until the column set is laid out. Since column sets are laid out after flow threads, use a more reliable way to include top border and padding. BUG=552615 Committed: https://crrev.com/0441243b0f371f2d98134a070ada9b149d95f32e Cr-Commit-Position: refs/heads/master@{#386213}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
LayoutColumnSet is probably the nastiest thing about the multicol implementation. :(
4 years, 8 months ago (2016-04-08 08:10:50 UTC) #2
leviw_travelin_and_unemployed
lgtm
4 years, 8 months ago (2016-04-08 20:37:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863413002/1
4 years, 8 months ago (2016-04-08 20:37:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 21:54:01 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 21:55:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0441243b0f371f2d98134a070ada9b149d95f32e
Cr-Commit-Position: refs/heads/master@{#386213}

Powered by Google App Engine
This is Rietveld 408576698