Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 1863403002: Add Visitor1<R, A> (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 8 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+595 lines, -15 lines) Patch
M pkg/compiler/lib/src/tree/nodes.dart View 1 85 chunks +595 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 8 months ago (2016-04-07 09:04:38 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1863403002/diff/1/pkg/compiler/lib/src/tree/nodes.dart File pkg/compiler/lib/src/tree/nodes.dart (right): https://codereview.chromium.org/1863403002/diff/1/pkg/compiler/lib/src/tree/nodes.dart#newcode113 pkg/compiler/lib/src/tree/nodes.dart:113: abstract class Visitor1<R, A> { Add dart-doc https://codereview.chromium.org/1863403002/diff/1/pkg/compiler/lib/src/tree/nodes.dart#newcode1521 ...
4 years, 8 months ago (2016-04-07 09:13:00 UTC) #3
Johnni Winther
https://codereview.chromium.org/1863403002/diff/1/pkg/compiler/lib/src/tree/nodes.dart File pkg/compiler/lib/src/tree/nodes.dart (right): https://codereview.chromium.org/1863403002/diff/1/pkg/compiler/lib/src/tree/nodes.dart#newcode113 pkg/compiler/lib/src/tree/nodes.dart:113: abstract class Visitor1<R, A> { On 2016/04/07 09:12:59, sigurdm ...
4 years, 8 months ago (2016-04-07 09:15:46 UTC) #4
Johnni Winther
4 years, 8 months ago (2016-04-07 09:16:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
450116f9d86e9d9c53f6f27cfc4785a18878bcef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698