Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: src/pdf/SkPDFMetadata.cpp

Issue 1863393004: SkPDF: fix pessimizing-move in PDFA code (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/pdf/SkPDFMetadata.cpp
diff --git a/src/pdf/SkPDFMetadata.cpp b/src/pdf/SkPDFMetadata.cpp
index 4ca1903d21b2a23fce8268b994b513044a30c7ec..a5476a2df0980e6755be98f62f3038be15c2f416 100644
--- a/src/pdf/SkPDFMetadata.cpp
+++ b/src/pdf/SkPDFMetadata.cpp
@@ -122,7 +122,7 @@ static SkString sk_string_printf(const char* format, ...) {
va_end(args);
SkASSERT(check == length);
SkASSERT(string[length] == '\0');
- return std::move(string);
+ return string;
#else // C99/C++11 standard vsnprintf
// TODO: When all compilers support this, remove windows-specific code.
va_list args;
@@ -143,7 +143,7 @@ static SkString sk_string_printf(const char* format, ...) {
va_end(args);
SkASSERT(check == length);
SkASSERT(string[length] == '\0');
- return std::move(string);
+ return string;
#endif
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698