Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1863393004: SkPDF: fix pessimizing-move in PDFA code (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pdf/SkPDFMetadata.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
hal.canary
I tried flipping this switch in Chromium, and this was necessary.
4 years, 8 months ago (2016-04-07 21:17:33 UTC) #3
tomhudson
lgtm
4 years, 8 months ago (2016-04-08 16:45:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863393004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863393004/1
4 years, 8 months ago (2016-04-08 16:45:26 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 16:55:26 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/050ab5d858980a7e5ebb4911bac649cb5d5f0c21

Powered by Google App Engine
This is Rietveld 408576698