Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1863363004:
[heap] Fix SemiSpace::Commit/GrowTo to deal with OOM (Closed)
|
Created:
4 years, 8 months ago by Michael Lippautz Modified:
4 years, 8 months ago Reviewers:
Hannes Payer (out of office) CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Fix SemiSpace::Commit/GrowTo to deal with OOM
R=hpayer@chromium.org
BUG=chromium:601041, chromium:601417, chromium:581412
LOG=N
Committed: https://crrev.com/6e281f1c0aff32d1426b5ec5afb6bb7f746cb786
Cr-Commit-Position: refs/heads/master@{#35333}
Patch Set 1 #Patch Set 2 : Also fix SemiSpace::GrowTo #Patch Set 3 : Fix compilation #Messages
Total messages: 24 (12 generated)
Excuse me sir, may I pass?
lgtm
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863363004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863363004/1
The CQ bit was unchecked by mlippautz@chromium.org
Description was changed from ========== [heap] Fix SemiSpace::Commit to deal with OOM R=hpayer@chromium.org BUG=chromium:601041, chromium:581412 LOG=N ========== to ========== [heap] Fix SemiSpace::Commit and SemiSpace::GrowTo to deal with OOM R=hpayer@chromium.org BUG=chromium:601041, chromium:581412, chromium:601417 LOG=N ==========
Description was changed from ========== [heap] Fix SemiSpace::Commit and SemiSpace::GrowTo to deal with OOM R=hpayer@chromium.org BUG=chromium:601041, chromium:581412, chromium:601417 LOG=N ========== to ========== [heap] Fix SemiSpace::Commit and SemiSpace::GrowTo to deal with OOM R=hpayer@chromium.org BUG=chromium:601041, chromium:601417, chromium:581412 LOG=N ==========
Description was changed from ========== [heap] Fix SemiSpace::Commit and SemiSpace::GrowTo to deal with OOM R=hpayer@chromium.org BUG=chromium:601041, chromium:601417, chromium:581412 LOG=N ========== to ========== [heap] Fix SemiSpace::Commit/GrowTo to deal with OOM R=hpayer@chromium.org BUG=chromium:601041, chromium:601417, chromium:581412 LOG=N ==========
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863363004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863363004/20001
Please take another look. I added a better solution as GrowTo was also affected.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...) v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863363004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863363004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863363004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863363004/40001
Message was sent while issue was closed.
Description was changed from ========== [heap] Fix SemiSpace::Commit/GrowTo to deal with OOM R=hpayer@chromium.org BUG=chromium:601041, chromium:601417, chromium:581412 LOG=N ========== to ========== [heap] Fix SemiSpace::Commit/GrowTo to deal with OOM R=hpayer@chromium.org BUG=chromium:601041, chromium:601417, chromium:581412 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [heap] Fix SemiSpace::Commit/GrowTo to deal with OOM R=hpayer@chromium.org BUG=chromium:601041, chromium:601417, chromium:581412 LOG=N ========== to ========== [heap] Fix SemiSpace::Commit/GrowTo to deal with OOM R=hpayer@chromium.org BUG=chromium:601041, chromium:601417, chromium:581412 LOG=N Committed: https://crrev.com/6e281f1c0aff32d1426b5ec5afb6bb7f746cb786 Cr-Commit-Position: refs/heads/master@{#35333} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6e281f1c0aff32d1426b5ec5afb6bb7f746cb786 Cr-Commit-Position: refs/heads/master@{#35333} |
