Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1863363003: [DevTools] Bring back bypassing CSP for eval in Runtime.evaluate (Closed)

Created:
4 years, 8 months ago by kozy
Modified:
4 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Bring back bypassing CSP for eval in Runtime.evaluate Some protocol clients like ChromeDriver use Runtime::evaluate to ignore eval policy. R=dgozman@chromium.org BUG=597820 Committed: https://crrev.com/3583be53effe6c17b74829610ca216a798e27bbc Cr-Commit-Position: refs/heads/master@{#385769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
kozy
Dmitry, please take a look.
4 years, 8 months ago (2016-04-07 05:44:22 UTC) #2
pfeldman
lgtm
4 years, 8 months ago (2016-04-07 06:12:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863363003/1
4 years, 8 months ago (2016-04-07 14:32:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 15:52:04 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3583be53effe6c17b74829610ca216a798e27bbc Cr-Commit-Position: refs/heads/master@{#385769}
4 years, 8 months ago (2016-04-07 15:53:00 UTC) #10
kozy
4 years, 8 months ago (2016-04-07 17:08:12 UTC) #12
Message was sent while issue was closed.
right issue: crbug.com/597820

Powered by Google App Engine
This is Rietveld 408576698