android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java - Issue 1863353002: 🎯 Fail if an instrumentation test is missing size annotation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java

Issue 1863353002: 🎯 Fail if an instrumentation test is missing size annotation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add annotation for SiteSettingsPreferencesTest.java Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/StandaloneAwQuotaManagerBridgeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java

index 612ae693f2c3890452ccb876ca361dd3809b3ff4..b7d3b7b1a5342e20b460a40b69fe4e7cbb68ce5c 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java

@@ -187,6 +187,7 @@ public class NavigationHistoryTest extends AwTestBase {

assertEquals(0, list.getCurrentEntryIndex());

}

+ @SmallTest

public void testFavicon() throws Throwable {

mWebServer.setResponseBase64("/" + CommonResources.FAVICON_FILENAME,

CommonResources.FAVICON_DATA_BASE64, CommonResources.getImagePngHeaders(false));