Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1863333004: [turbofan] Deprecate CompilationInfo::has_scope predicate. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Deprecate CompilationInfo::has_scope predicate. Now that we no longer compile stubs from JavaScript source, but have other means of generating stubs using our optimizing compilers, we can assume that scope analysis has happened whenever prologues are being assembled. R=bmeurer@chromium.org Committed: https://crrev.com/105777a03665f8cbaa2cb2219d0e0eae8765b040 Cr-Commit-Position: refs/heads/master@{#35329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -31 lines) Patch
M src/compiler.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler.cc View 4 chunks +2 lines, -12 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-07 09:17:13 UTC) #1
Michael Starzinger
4 years, 8 months ago (2016-04-07 09:27:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863333004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863333004/1
4 years, 8 months ago (2016-04-07 09:27:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 09:52:23 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 09:54:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/105777a03665f8cbaa2cb2219d0e0eae8765b040
Cr-Commit-Position: refs/heads/master@{#35329}

Powered by Google App Engine
This is Rietveld 408576698