Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 186333002: Add ftol workaround for VS2013 (Closed)

Created:
6 years, 9 months ago by scottmg
Modified:
6 years, 9 months ago
Reviewers:
cpu_(ooo_6.6-7.5), jam
CC:
chromium-reviews
Visibility:
Public.

Description

Add ftol workaround for VS2013 The .obj was taken from https://connect.microsoft.com/VisualStudio/feedback/details/808199 offered as a workaround by Microsoft. This fixes the floating point stack going unbalanced. This is fixed in Update 2, and can be removed once that's rolled out. R=cpu@chromium.org, jam@chromium.org BUG=348525 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254792

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
A build/win/ftol3.obj View Binary file 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
6 years, 9 months ago (2014-03-04 02:30:37 UTC) #1
scottmg
And +jam for OWNERS once cpu reviews.
6 years, 9 months ago (2014-03-04 02:58:17 UTC) #2
jam
lgtm
6 years, 9 months ago (2014-03-04 03:02:19 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
6 years, 9 months ago (2014-03-04 18:59:33 UTC) #4
scottmg
6 years, 9 months ago (2014-03-04 19:01:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r254792 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698