Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1863283002:
Make mojo::Callback<>::Runnable::Run non-const. (Closed)
|
Created:
4 years, 8 months ago by Reilly Grant (use Gerrit) Modified:
4 years, 8 months ago CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, haraken, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake mojo::Callback<>::Runnable::Run non-const.
This method was made const so that mojo::Callback<>::Run() could be
const but because of the indirection through RunnableHolder it doesn't
actually need to be. This removes the need for classes implementing the
Runnable interface to make some of their members mutable.
BUG=None
Committed: https://crrev.com/f8887e234a8a3e8b3fc4a2ee5e410ae1c79dbefa
Cr-Commit-Position: refs/heads/master@{#385964}
Patch Set 1 : #Patch Set 2 : Update FunctionPtrAdapter::Run. #Patch Set 3 : Fix Mojo network service. #Patch Set 4 : Fix Chrome OS build. #Patch Set 5 : Rebased. #
Messages
Total messages: 31 (15 generated)
Patchset #1 (id:1) has been deleted
reillyg@chromium.org changed reviewers: + yzshen@chromium.org
Please take a look.
lgtm
The CQ bit was checked by reillyg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863283002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
The CQ bit was checked by reillyg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org Link to the patchset: https://codereview.chromium.org/1863283002/#ps40001 (title: "Update FunctionPtrAdapter::Run.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863283002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
reillyg@chromium.org changed reviewers: + rockot@chromium.org
Please review //mojo/services/network.
you will also need to update chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc
reillyg@chromium.org changed reviewers: + hidehiko@chromium.org
hidehiko@, please review changes to chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc.
lgtm
chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc lgtm
The CQ bit was checked by reillyg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org Link to the patchset: https://codereview.chromium.org/1863283002/#ps80001 (title: "Fix Chrome OS build.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863283002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863283002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by reillyg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hidehiko@chromium.org, rockot@chromium.org, yzshen@chromium.org Link to the patchset: https://codereview.chromium.org/1863283002/#ps100001 (title: "Rebased.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863283002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863283002/100001
Message was sent while issue was closed.
Committed patchset #5 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Make mojo::Callback<>::Runnable::Run non-const. This method was made const so that mojo::Callback<>::Run() could be const but because of the indirection through RunnableHolder it doesn't actually need to be. This removes the need for classes implementing the Runnable interface to make some of their members mutable. BUG=None ========== to ========== Make mojo::Callback<>::Runnable::Run non-const. This method was made const so that mojo::Callback<>::Run() could be const but because of the indirection through RunnableHolder it doesn't actually need to be. This removes the need for classes implementing the Runnable interface to make some of their members mutable. BUG=None Committed: https://crrev.com/f8887e234a8a3e8b3fc4a2ee5e410ae1c79dbefa Cr-Commit-Position: refs/heads/master@{#385964} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/f8887e234a8a3e8b3fc4a2ee5e410ae1c79dbefa Cr-Commit-Position: refs/heads/master@{#385964} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
