Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1863273002: Fix background compilation queue access. Some cleanups. (Closed)

Created:
4 years, 8 months ago by srdjan
Modified:
4 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix background compilation queue access. Some cleanups. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/314bb44ea3c157cb27adca41f0c858085935ff3a

Patch Set 1 #

Patch Set 2 : more #

Total comments: 2

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -10 lines) Patch
M runtime/vm/compiler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/compiler.cc View 6 chunks +26 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download
M runtime/vm/profiler_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
srdjan
4 years, 8 months ago (2016-04-06 23:00:09 UTC) #2
siva
lgtm https://codereview.chromium.org/1863273002/diff/20001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1863273002/diff/20001/runtime/vm/compiler.cc#newcode1797 runtime/vm/compiler.cc:1797: delete function_queue; Now that you have a destructor ...
4 years, 8 months ago (2016-04-07 15:48:04 UTC) #3
srdjan
https://codereview.chromium.org/1863273002/diff/20001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1863273002/diff/20001/runtime/vm/compiler.cc#newcode1797 runtime/vm/compiler.cc:1797: delete function_queue; On 2016/04/07 15:48:04, siva wrote: > Now ...
4 years, 8 months ago (2016-04-07 16:12:47 UTC) #4
srdjan
4 years, 8 months ago (2016-04-07 16:13:14 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
314bb44ea3c157cb27adca41f0c858085935ff3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698