Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1863233002: Fix some broken tests. (Closed)

Created:
4 years, 8 months ago by nweiz
Modified:
4 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/vm_service_client.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some broken tests. Other broken tests are blocked on dart-lang/sdk#26203. Closes #5 R=kevmoo@google.com Committed: https://github.com/dart-lang/vm_service_client/commit/28b9d87edf3345377dc15b9306111fd9756e08f4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/instance_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M test/isolate_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 8 months ago (2016-04-06 21:26:36 UTC) #1
kevmoo
On fix good, the other one – not so much https://codereview.chromium.org/1863233002/diff/1/test/instance_test.dart File test/instance_test.dart (right): https://codereview.chromium.org/1863233002/diff/1/test/instance_test.dart#newcode334 ...
4 years, 8 months ago (2016-04-06 23:13:15 UTC) #2
nweiz
Code review changes
4 years, 8 months ago (2016-04-07 20:26:05 UTC) #3
nweiz
Committed patchset #2 (id:20001) manually as 28b9d87edf3345377dc15b9306111fd9756e08f4 (presubmit successful).
4 years, 8 months ago (2016-04-07 20:26:49 UTC) #5
nweiz
4 years, 8 months ago (2016-04-07 20:27:17 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1863233002/diff/1/test/instance_test.dart
File test/instance_test.dart (right):

https://codereview.chromium.org/1863233002/diff/1/test/instance_test.dart#new...
test/instance_test.dart:334: expect(value.typeClass.name, equals("List"));
On 2016/04/06 23:13:15, kevmoo wrote:
> This line now fails – expects _GrowableList

Womp womp. Done.

Powered by Google App Engine
This is Rietveld 408576698