Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1863223002: Convert //printing to use std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //printing to use std::unique_ptr BUG=554298 R=vitalybuka@chromium.org Committed: https://crrev.com/c3df9bafc8db94bd613fbd76c61abe5057f7a82d Cr-Commit-Position: refs/heads/master@{#385914}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -104 lines) Patch
M printing/backend/print_backend_win.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M printing/backend/printing_info_win.h View 3 chunks +4 lines, -3 lines 0 comments Download
M printing/backend/printing_info_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M printing/backend/win_helper.h View 2 chunks +8 lines, -8 lines 0 comments Download
M printing/backend/win_helper.cc View 9 chunks +16 lines, -16 lines 0 comments Download
M printing/emf_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
M printing/emf_win.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M printing/emf_win_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M printing/pdf_metafile_skia.h View 3 chunks +4 lines, -3 lines 0 comments Download
M printing/pdf_metafile_skia.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M printing/printed_document.h View 2 chunks +2 lines, -2 lines 0 comments Download
M printing/printed_document.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printed_page.h View 3 chunks +4 lines, -3 lines 0 comments Download
M printing/printed_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printed_page_unittest.cc View 5 chunks +10 lines, -20 lines 0 comments Download
M printing/printing_context.h View 2 chunks +2 lines, -2 lines 0 comments Download
M printing/printing_context.cc View 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_android.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M printing/printing_context_linux.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M printing/printing_context_mac.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M printing/printing_context_no_system_dialog.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M printing/printing_context_win.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_win.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M printing/printing_context_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
4 years, 8 months ago (2016-04-06 20:06:53 UTC) #1
dcheng
+thestig, mind taking a look? I guess vitaly might be busy.
4 years, 8 months ago (2016-04-07 19:45:52 UTC) #3
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-07 20:44:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863223002/1
4 years, 8 months ago (2016-04-07 20:57:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 23:09:53 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 23:10:50 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c3df9bafc8db94bd613fbd76c61abe5057f7a82d
Cr-Commit-Position: refs/heads/master@{#385914}

Powered by Google App Engine
This is Rietveld 408576698