Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1863143002: Use correct clip container when computing acl for scroll children (Closed)

Created:
4 years, 8 months ago by Ian Vollick
Modified:
4 years, 7 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct clip container when computing acl for scroll children Kudos to erick@ for the reduced test case. BUG=603997 Committed: https://crrev.com/94d5fad34f0351e61fd658ca4ed93648c415620d Cr-Commit-Position: refs/heads/master@{#390199}

Patch Set 1 #

Patch Set 2 : Fix ancestor clipping layer sizing #

Patch Set 3 : update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
Ian Vollick
4 years, 8 months ago (2016-04-19 19:03:46 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863143002/20001
4 years, 8 months ago (2016-04-19 19:04:20 UTC) #6
Xianzhu
lgtm
4 years, 8 months ago (2016-04-19 19:10:11 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/213769)
4 years, 8 months ago (2016-04-19 20:25:20 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863143002/20001
4 years, 8 months ago (2016-04-20 15:45:45 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/208269)
4 years, 8 months ago (2016-04-20 17:06:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863143002/40001
4 years, 7 months ago (2016-04-27 20:28:23 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-27 21:43:50 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/94d5fad34f0351e61fd658ca4ed93648c415620d Cr-Commit-Position: refs/heads/master@{#390199}
4 years, 7 months ago (2016-04-30 17:13:30 UTC) #19
chrishtr
4 years, 7 months ago (2016-05-05 18:32:38 UTC) #21
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1953833002/ by chrishtr@chromium.org.

The reason for reverting is: Caused issue 608410.

Powered by Google App Engine
This is Rietveld 408576698