Chromium Code Reviews

Issue 1863123002: [crankshaft] Make infinite loop preserve control flow. (Closed)

Created:
4 years, 8 months ago by Jarin
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Make infinite loops preserve control flow. We have to preserve control flow so that the liveness analysis is less confused. This CL fixes loops to preserve teh original control flow. BUG=chromium:599710 LOG=n Committed: https://crrev.com/3df0a8c1f226984118cadb79db2872f8b98296c9 Cr-Commit-Position: refs/heads/master@{#35318}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+71 lines, -17 lines)
M src/crankshaft/hydrogen.cc View 4 chunks +22 lines, -17 lines 0 comments
A test/mjsunit/regress/regress-599710.js View 1 chunk +49 lines, -0 lines 0 comments

Messages

Total messages: 10 (5 generated)
Jarin
Could you take a look, please?
4 years, 8 months ago (2016-04-06 21:15:15 UTC) #3
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-07 01:32:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863123002/1
4 years, 8 months ago (2016-04-07 05:34:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 05:36:35 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 05:36:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3df0a8c1f226984118cadb79db2872f8b98296c9
Cr-Commit-Position: refs/heads/master@{#35318}

Powered by Google App Engine