Chromium Code Reviews
DescriptionRevert of Send a SIGKILL to masters after 10 seconds if they don't exit from SIGTERM (patchset #4 id:60001 of https://codereview.chromium.org/1754103002/ )
Reason for revert:
In addition to the problems in crbug.com/599874 pointed out by nodir@, I think that this logic is unnecessary given the data in https://bugs.chromium.org/p/chromium/issues/detail?id=588118. Anything stale was from well before proper logic was implemented to handle duplicates (https://chromiumcodereview.appspot.com/1808383002/). Since this may not be necessary anymore and actively causing trouble, I'm reverting. I'd like to continue this discussion because I think it's a good issue to have. Perhaps we can come up with a better way to manage our daemons and ensure only one is running at a time.
Original issue's description:
> Send a SIGKILL to masters after 10 seconds if they don't exit from SIGTERM
>
> BUG=
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299527
TBR=pgervais@chromium.org,chrishall@chromium.org,dnj@chromium.org,nodir@chromium.org,dsansome@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299750
Patch Set 1 #
Messages
Total messages: 6 (1 generated)
|
||||||||||||||||||||||||||||