Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1863083003: Revert of Send a SIGKILL to masters after 10 seconds if they don't exit from SIGTERM (Closed)

Created:
4 years, 8 months ago by ghost stip (do not use)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Send a SIGKILL to masters after 10 seconds if they don't exit from SIGTERM (patchset #4 id:60001 of https://codereview.chromium.org/1754103002/ ) Reason for revert: In addition to the problems in crbug.com/599874 pointed out by nodir@, I think that this logic is unnecessary given the data in https://bugs.chromium.org/p/chromium/issues/detail?id=588118. Anything stale was from well before proper logic was implemented to handle duplicates (https://chromiumcodereview.appspot.com/1808383002/). Since this may not be necessary anymore and actively causing trouble, I'm reverting. I'd like to continue this discussion because I think it's a good issue to have. Perhaps we can come up with a better way to manage our daemons and ensure only one is running at a time. Original issue's description: > Send a SIGKILL to masters after 10 seconds if they don't exit from SIGTERM > > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299527 TBR=pgervais@chromium.org,chrishall@chromium.org,dnj@chromium.org,nodir@chromium.org,dsansome@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299750

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -39 lines) Patch
M masters/master-common-rules.mk View 1 chunk +1 line, -1 line 0 comments Download
D scripts/master/kill_pidfile.sh View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ghost stip (do not use)
Created Revert of Send a SIGKILL to masters after 10 seconds if they don't exit ...
4 years, 8 months ago (2016-04-06 20:10:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863083003/1
4 years, 8 months ago (2016-04-06 20:10:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299750
4 years, 8 months ago (2016-04-06 20:14:11 UTC) #4
pgervais
On 2016/04/06 20:14:11, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 8 months ago (2016-04-06 21:37:38 UTC) #5
dsansome
4 years, 8 months ago (2016-04-07 04:23:41 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698