Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1863073003: [Android] Fix sync shell isolate location in GN. (Closed)

Created:
4 years, 8 months ago by jbudorick
Modified:
4 years, 8 months ago
Reviewers:
Ted C, timvolodine
CC:
chromium-reviews, agrieve
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix sync shell isolate location in GN. BUG=600979 TBR=tedchoc@chromium.org,timvolodine@chromium.org Committed: https://crrev.com/34bba8ce966ff2f3d6c24d66f165b07c48f1ca25 Cr-Commit-Position: refs/heads/master@{#385460}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/android/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
jbudorick
There is no device isolate file. //chrome/android/chrome_sync_shell_test_apk.isolate is for swarming, and //chrome/chrome_sync_shell_test_apk.isolate doesn't exist.
4 years, 8 months ago (2016-04-06 14:01:54 UTC) #3
jbudorick
On 2016/04/06 14:01:54, jbudorick wrote: > There is no device isolate file. > //chrome/android/chrome_sync_shell_test_apk.isolate is ...
4 years, 8 months ago (2016-04-06 14:02:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863073003/20001
4 years, 8 months ago (2016-04-06 14:02:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-06 14:46:16 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/34bba8ce966ff2f3d6c24d66f165b07c48f1ca25 Cr-Commit-Position: refs/heads/master@{#385460}
4 years, 8 months ago (2016-04-06 14:47:37 UTC) #9
timvolodine
4 years, 8 months ago (2016-04-06 14:51:35 UTC) #10
Message was sent while issue was closed.
On 2016/04/06 14:47:37, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/34bba8ce966ff2f3d6c24d66f165b07c48f1ca25
> Cr-Commit-Position: refs/heads/master@{#385460}

lgtm

Powered by Google App Engine
This is Rietveld 408576698