src/fonts/SkRandomScalerContext.h - Issue 1863013003: Pass effects directly to fontcache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/fonts/SkRandomScalerContext.h

Issue 1863013003: Pass effects directly to fontcache (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: removed DUMMY effects Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/fonts/SkRandomScalerContext.h

diff --git a/src/fonts/SkRandomScalerContext.h b/src/fonts/SkRandomScalerContext.h

index 24b203f05c71175853cb92240744aef2e8207d77..0e08f4b1ae7e08aea3f7b9339e8a4f7163f1e776 100644

--- a/src/fonts/SkRandomScalerContext.h

+++ b/src/fonts/SkRandomScalerContext.h

@@ -25,7 +25,8 @@ public:

const SkPaint& paint() const { return fPaint; }

protected:

- SkScalerContext* onCreateScalerContext(const SkDescriptor*) const override;

+ SkScalerContext* onCreateScalerContext(const SkScalerContextEffects&,

+ const SkDescriptor*) const override;

void onFilterRec(SkScalerContextRec*) const override;

SkAdvancedTypefaceMetrics* onGetAdvancedTypefaceMetrics(

PerGlyphInfo,