core/fxcrt/include/fx_string.h - Issue 1862953004: Make CFX_WideString::FromLocal() take a CFX_ByteStringC arg

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/include/fx_string.h

Issue 1862953004: Make CFX_WideString::FromLocal() take a CFX_ByteStringC arg (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Propogate into CFX_CharMap methods, avoid silent alloc. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fxcrt/include/fx_string.h

diff --git a/core/fxcrt/include/fx_string.h b/core/fxcrt/include/fx_string.h

index 75957950113c08ed0b82f83bd625c7517f78c0b4..17be346b0fbf7b64d2e62dacdabb3f3832aaa677 100644

--- a/core/fxcrt/include/fx_string.h

+++ b/core/fxcrt/include/fx_string.h

@@ -504,8 +504,8 @@ class CFX_WideString {

~CFX_WideString();

- static CFX_WideString FromLocal(const CFX_ByteString& str);

- static CFX_WideString FromCodePage(const CFX_ByteString& str,

+ static CFX_WideString FromLocal(const CFX_ByteStringC& str);

+ static CFX_WideString FromCodePage(const CFX_ByteStringC& str,

uint16_t codepage);

static CFX_WideString FromUTF8(const CFX_ByteStringC& str);

« core/fpdfdoc/doc_basic.cpp ('K') | « core/fxcrt/include/fx_basic.h ('k') | fpdfsdk/fsdk_mgr.cpp » ('j') | no next file with comments »