core/fxcrt/fx_basic_bstring.cpp - Issue 1862953004: Make CFX_WideString::FromLocal() take a CFX_ByteStringC arg

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/fx_basic_bstring.cpp

Issue 1862953004: Make CFX_WideString::FromLocal() take a CFX_ByteStringC arg (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Propogate into CFX_CharMap methods, avoid silent alloc. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fxcrt/fx_basic_bstring.cpp

diff --git a/core/fxcrt/fx_basic_bstring.cpp b/core/fxcrt/fx_basic_bstring.cpp

index 3e4e9c354e912df11e2941fcaefa6c4e1c5e9f99..1c48b3defa136c357e9d573973142558626d48d5 100644

--- a/core/fxcrt/fx_basic_bstring.cpp

+++ b/core/fxcrt/fx_basic_bstring.cpp

@@ -822,7 +822,7 @@ CFX_ByteString CFX_ByteString::FromUnicode(const FX_WCHAR* str,

// static

CFX_ByteString CFX_ByteString::FromUnicode(const CFX_WideString& str) {

- return CFX_CharMap::GetByteString(0, str);

+ return CFX_CharMap::GetByteString(0, str.AsWideStringC());

}

int CFX_ByteString::Compare(const CFX_ByteStringC& str) const {

« core/fpdfdoc/doc_basic.cpp ('K') | « core/fpdfdoc/doc_form.cpp ('k') | core/fxcrt/fx_basic_wstring.cpp » ('j') | no next file with comments »