Make CFX_WideString::FromLocal() take a CFX_ByteStringC arg

Make CFX_WideString::FromLocal() take a CFX_ByteStringC arg

It doesn't persist the string beyond the duration of the
call, hence it should take the *StringC variant. Doing so
avoids some allocs by changing to the *StringC ctor in a few
places, at the cost of some explicit .ToByteStringC() calls
(which are cheap).

Committed: https://pdfium.googlesource.com/pdfium/+/8b36e5cc3d5f5f579c6b060e2c40b896a4b02bc0

[Tom Sepez, 2016-04-06 20:51:18]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-06 20:51:18]

Lei, please review.

[Tom Sepez, 2016-04-06 20:52:30]

Description was changed from

==========
Make CFX_WideString::FromLocal() take a CFX_ByteStringC arg

It doesn't persist the string beyond the duration of the call,
hence this should take the *StringC variant.
==========

to

==========
Make CFX_WideString::FromLocal() take a CFX_ByteStringC arg

It doesn't persist the string beyond the duration of the
call, hence this should take the *StringC variant. Doing so
avoids some allocs by changing to the *StringC ctor in a few
places, at the cost of some explicit .ToByteStringC() calls
(which are cheap).
==========

[Tom Sepez, 2016-04-06 20:52:55]

Description was changed from

==========
Make CFX_WideString::FromLocal() take a CFX_ByteStringC arg

It doesn't persist the string beyond the duration of the
call, hence this should take the *StringC variant. Doing so
avoids some allocs by changing to the *StringC ctor in a few
places, at the cost of some explicit .ToByteStringC() calls
(which are cheap).
==========

to

==========
Make CFX_WideString::FromLocal() take a CFX_ByteStringC arg

It doesn't persist the string beyond the duration of the
call, hence it should take the *StringC variant. Doing so
avoids some allocs by changing to the *StringC ctor in a few
places, at the cost of some explicit .ToByteStringC() calls
(which are cheap).
==========

[Lei Zhang, 2016-04-07 19:21:59]

lgtm

https://codereview.chromium.org/1862953004/diff/20001/core/fpdfdoc/doc_basic.cpp
File core/fpdfdoc/doc_basic.cpp (right):

https://codereview.chromium.org/1862953004/diff/20001/core/fpdfdoc/doc_basic....
core/fpdfdoc/doc_basic.cpp:319:
CFX_WideString::FromLocal(pDict->GetStringBy("F").AsByteStringC());
Use GetConstStringBy() instead?

[Tom Sepez, 2016-04-08 15:47:29]

https://codereview.chromium.org/1862953004/diff/20001/core/fpdfdoc/doc_basic.cpp
File core/fpdfdoc/doc_basic.cpp (right):

https://codereview.chromium.org/1862953004/diff/20001/core/fpdfdoc/doc_basic....
core/fpdfdoc/doc_basic.cpp:319:
CFX_WideString::FromLocal(pDict->GetStringBy("F").AsByteStringC());
On 2016/04/07 19:21:59, Lei Zhang wrote:
> Use GetConstStringBy() instead?

Done.

[Tom Sepez, 2016-04-08 15:47:34]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-04-08 15:47:35]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1862953004/#ps60001
(title: "Use GetConstStringBy().")

[commit-bot: I haz the power, 2016-04-08 15:47:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862953004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862953004/60001

[commit-bot: I haz the power, 2016-04-08 16:00:39]

Description was changed from

==========
Make CFX_WideString::FromLocal() take a CFX_ByteStringC arg

It doesn't persist the string beyond the duration of the
call, hence it should take the *StringC variant. Doing so
avoids some allocs by changing to the *StringC ctor in a few
places, at the cost of some explicit .ToByteStringC() calls
(which are cheap).
==========

to

==========
Make CFX_WideString::FromLocal() take a CFX_ByteStringC arg

It doesn't persist the string beyond the duration of the
call, hence it should take the *StringC variant. Doing so
avoids some allocs by changing to the *StringC ctor in a few
places, at the cost of some explicit .ToByteStringC() calls
(which are cheap).

Committed:
https://pdfium.googlesource.com/pdfium/+/8b36e5cc3d5f5f579c6b060e2c40b896a4b0...
==========

[commit-bot: I haz the power, 2016-04-08 16:00:40]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/8b36e5cc3d5f5f579c6b060e2c40b896a4b0...