third_party/WebKit/LayoutTests/resources/bluetooth/requestDevice-in-iframe.html - Issue 1862953002: Disallow use of Web Bluetooth from cross-origin iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/resources/bluetooth/requestDevice-in-iframe.html

Issue 1862953002: Disallow use of Web Bluetooth from cross-origin iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Add a test. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/bluetooth/https/requestDevice/cross-origin-iframe.html ('k') | third_party/WebKit/LayoutTests/resources/bluetooth/requestDevice-in-sandboxed-iframe.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/resources/bluetooth/requestDevice-in-iframe.html

diff --git a/third_party/WebKit/LayoutTests/resources/bluetooth/requestDevice-in-iframe.html b/third_party/WebKit/LayoutTests/resources/bluetooth/requestDevice-in-iframe.html

index ac51b07440dd895f2b8494d6aee43a5293b1fadc..870e7a81354e12d15f5ac7bc13cc438fae46c9a0 100644

--- a/third_party/WebKit/LayoutTests/resources/bluetooth/requestDevice-in-iframe.html

+++ b/third_party/WebKit/LayoutTests/resources/bluetooth/requestDevice-in-iframe.html

@@ -1,6 +1,8 @@

<!DOCTYPE html>

window.onmessage = messageEvent => {

+ // For requestDevice to work, 'Go' should be sent while

+ // handling a user gesture.

if (messageEvent.data === 'Go') {

navigator.bluetooth.requestDevice({

filters: [{services: ['generic_access']}]

@@ -11,8 +13,7 @@

parent.postMessage('FAIL: requestDevice in iframe returned ' + device, '*');

}

}).catch(err => {

- console.error(err);

- parent.postMessage('FAIL: ' + err, '*');

+ parent.postMessage(err.name + ': ' + err.message, '*');

});

}

};