third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom - Issue 1862953002: Disallow use of Web Bluetooth from cross-origin iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

Issue 1862953002: Disallow use of Web Bluetooth from cross-origin iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/bluetooth/requestDevice-sandboxed-iframe.html ('K') | « third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp ('k') | url/origin.h » ('j') | url/origin.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

diff --git a/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom b/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

index 66233dd4c522e7424eb995acbd6ff69b56191ad0..f70113ec8a2d9e00a12e65c2e3c8b2e13013decb 100644

--- a/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

+++ b/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

@@ -61,7 +61,7 @@ enum WebBluetoothError {

BLACKLISTED_WRITE,

NOT_ALLOWED_TO_ACCESS_SERVICE,

REQUEST_DEVICE_WITH_BLACKLISTED_UUID,

- REQUEST_DEVICE_WITH_UNIQUE_ORIGIN,

+ REQUEST_DEVICE_FROM_CROSS_ORIGIN_IFRAME,

REQUEST_DEVICE_WITHOUT_FRAME,

// SyntaxError:

// TODO(ortuno): Remove once we no longer use IPC.