Add (another) argument to break git locks in gclient.

Add (another) argument to break git locks in gclient.

This will clean up index.lock and refs/heads/master.lock-style locks when
invoked as part of the update_scripts step on the bots.

R=dpranke@chromium.org, estaab@chromium.org, pgervais@chromium.org
BUG=421769
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299737

[iannucci, 2016-04-06 02:27:19]

PTAL

[Dirk Pranke, 2016-04-06 02:47:45]

lgtm.

Does git actually use multiple lock files? only index.lock is particularly
familiar, and maybe if we just wanted to catch that one the code would be
simpler and safer?

[iannucci, 2016-04-06 03:05:04]

I've seen the per ref locks show up on the bots too

On Tue, Apr 5, 2016, 19:47 <dpranke@chromium.org> wrote:

> lgtm.
>
> Does git actually use multiple lock files? only index.lock is particularly
> familiar, and maybe if we just wanted to catch that one the code would be
> simpler and safer?
>
> https://codereview.chromium.org/1862943002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[estaab, 2016-04-06 03:20:11]

lgtm

[pgervais, 2016-04-06 15:53:30]

lgtm with two suggestions

https://codereview.chromium.org/1862943002/diff/1/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/1862943002/diff/1/gclient_scm.py#newcode339
gclient_scm.py:339: for path, _, fils in os.walk(git_dir):
fils?

Suggestion: fils -> filenames ; fname -> filename

https://codereview.chromium.org/1862943002/diff/1/tests/gclient_scm_test.py
File tests/gclient_scm_test.py (right):

https://codereview.chromium.org/1862943002/diff/1/tests/gclient_scm_test.py#n...
tests/gclient_scm_test.py:531: "breaking lock.*\.git/index\.lock")
I would also check that the file has actually been deleted, which is more
important than the log message imho.

[iannucci, 2016-04-06 17:29:18]

https://codereview.chromium.org/1862943002/diff/1/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/1862943002/diff/1/gclient_scm.py#newcode339
gclient_scm.py:339: for path, _, fils in os.walk(git_dir):
On 2016/04/06 15:53:30, pgervais wrote:
> fils?
> 
> Suggestion: fils -> filenames ; fname -> filename

Done.

https://codereview.chromium.org/1862943002/diff/1/tests/gclient_scm_test.py
File tests/gclient_scm_test.py (right):

https://codereview.chromium.org/1862943002/diff/1/tests/gclient_scm_test.py#n...
tests/gclient_scm_test.py:531: "breaking lock.*\.git/index\.lock")
On 2016/04/06 15:53:30, pgervais wrote:
> I would also check that the file has actually been deleted, which is more
> important than the log message imho.

Done.

[iannucci, 2016-04-06 17:30:20]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2016-04-06 17:30:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, estaab@chromium.org, pgervais@chromium.org
Link to the patchset: https://codereview.chromium.org/1862943002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-04-06 17:30:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862943002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862943002/20001

[commit-bot: I haz the power, 2016-04-06 17:33:30]

Description was changed from

==========
Add (another) argument to break git locks in gclient.

This will clean up index.lock and refs/heads/master.lock-style locks when
invoked as part of the update_scripts step on the bots.

R=dpranke@chromium.org, estaab@chromium.org, pgervais@chromium.org
BUG=421769
==========

to

==========
Add (another) argument to break git locks in gclient.

This will clean up index.lock and refs/heads/master.lock-style locks when
invoked as part of the update_scripts step on the bots.

R=dpranke@chromium.org, estaab@chromium.org, pgervais@chromium.org
BUG=421769

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299737
==========

[commit-bot: I haz the power, 2016-04-06 17:33:33]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299737