Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 1862903003: Print the isolate's sticky error if it has one. (Closed)

Created:
4 years, 8 months ago by Cutch
Modified:
4 years, 8 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Print the isolate's sticky error if it has one. - Bump protocol version to 3.4 to match service.md. - Added note in changelog about 'none' pause event. - Print the isolate's sticky error if it has one. Fixes #26203 Committed: https://github.com/dart-lang/sdk/commit/1c4f63df6c1c7a2c148f7e1679a36a70ed38e870

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M runtime/observatory/tests/service/get_version_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service/service.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 8 months ago (2016-04-06 23:48:39 UTC) #3
kevmoo
On 2016/04/06 23:48:39, Cutch wrote: A test for this fix?
4 years, 8 months ago (2016-04-07 00:27:23 UTC) #4
Cutch
On 2016/04/06 23:48:32, Cutch wrote: > mailto:johnmccutchan@google.com changed reviewers: > + mailto:turnidge@google.com Todd reviewed this ...
4 years, 8 months ago (2016-04-07 22:31:18 UTC) #5
Cutch
4 years, 8 months ago (2016-04-07 22:31:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1c4f63df6c1c7a2c148f7e1679a36a70ed38e870 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698