MediaStreamAudioDestinationNode should inherit AudioNode

MediaStreamAudioDestinationNode should inherit AudioNode

MediaStreamAudioDestinationNode should inherit AudioNode, not AudioSourceNode
according to the specification:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#MediaElementAudioSourceNode

The inheritance was correct on native side but incorrect on Web IDL / JS side.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153767

[do-not-use, 2013-07-08 10:53:00]

This is blocking issue 18778002 as static casting from
MediaStreamAudioDestinationNode to AudioNode does not compile at the moment.

[haraken, 2013-07-08 10:58:39]

LGTM. Would you check other browsers' behavior just in case?

[do-not-use, 2013-07-08 11:11:25]

On 2013/07/08 10:58:39, haraken wrote:
> LGTM. Would you check other browsers' behavior just in case?

Isn't Web Audio only supported by Blink / WebKit?

Also, the compatibility risk is low because AudioSourceNode inherits AudioNode
and does not add any API of its own.

[haraken, 2013-07-08 11:18:00]

> Isn't Web Audio only supported by Blink / WebKit?

You're right. Thanks.

[arv (Not doing code reviews), 2013-07-08 15:38:11]

On 2013/07/08 11:18:00, haraken wrote:
> > Isn't Web Audio only supported by Blink / WebKit?
> 
> You're right. Thanks.

Firefox has partial Web Audio support.

The spec removed AudioSourceNode so I think this is all good, but please let
Chris Rogers have the final word on this.

[Chris Rogers, 2013-07-08 19:14:16]

Thanks Christophe - lgtm

[arv (Not doing code reviews), 2013-07-08 21:35:43]

LGTM

https://chromiumcodereview.appspot.com/18629003/diff/4001/LayoutTests/webaudi...
File LayoutTests/webaudio/mediastreamaudiodestinationnode.html (right):

https://chromiumcodereview.appspot.com/18629003/diff/4001/LayoutTests/webaudi...
LayoutTests/webaudio/mediastreamaudiodestinationnode.html:17: var
mediaStreamDestination = 0;
why 0?

[commit-bot: I haz the power, 2013-07-09 06:35:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18629003/4001

[do-not-use, 2013-07-09 06:37:27]

https://codereview.chromium.org/18629003/diff/4001/LayoutTests/webaudio/media...
File LayoutTests/webaudio/mediastreamaudiodestinationnode.html (right):

https://codereview.chromium.org/18629003/diff/4001/LayoutTests/webaudio/media...
LayoutTests/webaudio/mediastreamaudiodestinationnode.html:17: var
mediaStreamDestination = 0;
On 2013/07/08 21:35:43, arv wrote:
> why 0?

For consistency with the line above but this is not needed indeed. I'll remove
the initialization.

[commit-bot: I haz the power, 2013-07-09 07:06:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18629003/16001

[commit-bot: I haz the power, 2013-07-09 09:03:10]

Change committed as 153767