Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/harfbuzz-ng/harfbuzz.gyp

Issue 1862893002: Rework how use_system_harfbuzz works a bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/harfbuzz-ng/BUILD.gn ('K') | « third_party/harfbuzz-ng/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/harfbuzz-ng/harfbuzz.gyp
diff --git a/third_party/harfbuzz-ng/harfbuzz.gyp b/third_party/harfbuzz-ng/harfbuzz.gyp
index b9be8ae2f6c4789e15f540bcf7636ea3eb085c79..2064a26c02e01b4d3f81381a484ad41250801fa0 100644
--- a/third_party/harfbuzz-ng/harfbuzz.gyp
+++ b/third_party/harfbuzz-ng/harfbuzz.gyp
@@ -7,17 +7,12 @@
'../../build/win_precompile.gypi',
],
'variables': {
- 'conditions': [
- ['OS=="linux" and chromeos==1', {
- # Since version 1.31.0, pangoft2 which we depend on pulls in harfbuzz
- # anyways. However, we want to have control of the version of harfbuzz
- # we use, so don't use system harfbuzz unless we are building for
- # chrome os, where we have the system harfbuzz under control.
- 'use_system_harfbuzz%': '<!(python ../../build/check_return_value.py <(pkg-config) --atleast-version=1.31.0 pangoft2)',
- }, {
- 'use_system_harfbuzz': 0,
- }],
- ],
+ # Blink uses a cutting-edge version of Harfbuzz; most Linux distros do not
+ # contain a new enough version of the code to work correctly. However,
+ # ChromeOS chroots (i.e, real ChromeOS builds for devices) do contain a
+ # new enough version of the library, and so this variable exists so that
+ # ChromeOS can build against the system lib and keep binary sizes smaller.
+ 'use_system_harfbuzz%': 0,
},
'conditions': [
['use_system_harfbuzz==0', {
« third_party/harfbuzz-ng/BUILD.gn ('K') | « third_party/harfbuzz-ng/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698