Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1862853002: Makes WindowTree::SetFocus(null) work (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes WindowTree::SetFocus(null) work We need this so clients can clear focus as necessary. BUG=599552 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/fe2dda84ac99039a639e6be859ce087474cad166 Cr-Commit-Position: refs/heads/master@{#385550}

Patch Set 1 #

Patch Set 2 : fg #

Patch Set 3 : cleanup #

Patch Set 4 : moar cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -21 lines) Patch
M components/mus/public/cpp/lib/window_tree_client_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M components/mus/public/cpp/window.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/window_tree_connection.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/mus/public/interfaces/window_tree.mojom View 1 chunk +7 lines, -0 lines 0 comments Download
M components/mus/ws/default_access_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_manager_client_unittest.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M components/mus/ws/window_server.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_server.cc View 2 chunks +18 lines, -6 lines 0 comments Download
M components/mus/ws/window_tree.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sky
4 years, 8 months ago (2016-04-05 23:15:23 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 8 months ago (2016-04-06 15:53:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862853002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862853002/60001
4 years, 8 months ago (2016-04-06 20:31:57 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-06 20:37:49 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 20:40:14 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/fe2dda84ac99039a639e6be859ce087474cad166
Cr-Commit-Position: refs/heads/master@{#385550}

Powered by Google App Engine
This is Rietveld 408576698