Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1862793003: mac: Fix flickering of install extension window. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
Reviewers:
tapted
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Fix flickering of install extension window. Changing properties of an NSWindow can synchronously affect the display. Hide the window before it is added to the NSWindow hierarchy. Then animate it in when it is already in the correct location. BUG=595239 Committed: https://crrev.com/fce13c0eee832c68383fed90c9e01ee22fd893ad Cr-Commit-Position: refs/heads/master@{#385425}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
erikchen
tapted: Please review.
4 years, 8 months ago (2016-04-06 01:15:28 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862793003/20001
4 years, 8 months ago (2016-04-06 01:17:26 UTC) #5
tapted
lgtm
4 years, 8 months ago (2016-04-06 01:20:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862793003/20001
4 years, 8 months ago (2016-04-06 01:21:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/207629)
4 years, 8 months ago (2016-04-06 07:19:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862793003/20001
4 years, 8 months ago (2016-04-06 09:06:59 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-06 09:51:54 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 09:53:05 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fce13c0eee832c68383fed90c9e01ee22fd893ad
Cr-Commit-Position: refs/heads/master@{#385425}

Powered by Google App Engine
This is Rietveld 408576698