scripts/slave/recipe_modules/chromium/api.py - Issue 1862773003: Remove references to crash_service, which is no longer needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 1862773003: Remove references to crash_service, which is no longer needed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: update expectations Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/chromium/api.py

diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py

index 6afe82f6668479d2ad8ff88de6e421584088625f..a668ba5606ee0c78ad7d98688121847e8a43f73d 100644

--- a/scripts/slave/recipe_modules/chromium/api.py

+++ b/scripts/slave/recipe_modules/chromium/api.py

@@ -610,14 +610,6 @@ class ChromiumApi(recipe_api.RecipeApi):

self.package_repo_resource('scripts', 'slave', 'cleanup_temp.py')],

infra_step=True)

- def crash_handler(self):

- self.m.python(

- 'start_crash_service',

- self.package_repo_resource(

- 'scripts', 'slave', 'chromium', 'run_crash_handler.py'),

- ['--target', self.c.build_config_fs],

- infra_step=True)

def process_dumps(self, **kwargs):

# Dumps are especially useful when other steps (e.g. tests) are failing.

try:

« no previous file with comments | « scripts/slave/kill_processes.py ('k') | scripts/slave/recipe_modules/chromium_tests/api.py » ('j') | no next file with comments »