Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1862753003: Refactoring: Avoid redundant checks in SingletonFor (Closed)

Created:
4 years, 8 months ago by Clemens Hammacher
Modified:
4 years, 8 months ago
Reviewers:
titzer, clemensh
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refactoring: Avoid redundant checks in SingletonFor SingletonFor(type, state) returns NULL and does nothing whenever SingletonFor(type) also return NULL. So checking this beforehand is redundant. This is my first CL, so I also use it to get familiar with the system. R=titzer@chromium.org BUG= Committed: https://crrev.com/9a65c0ef03c523f04fd35cf3e31033e99b79c622 Cr-Commit-Position: refs/heads/master@{#35285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M src/frames.cc View 3 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Clemens Hammacher
4 years, 8 months ago (2016-04-06 08:32:54 UTC) #1
titzer
lgtm if description is updated as per in-person discussion
4 years, 8 months ago (2016-04-06 08:37:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862753003/1
4 years, 8 months ago (2016-04-06 08:38:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862753003/1
4 years, 8 months ago (2016-04-06 08:50:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 08:56:30 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 08:57:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a65c0ef03c523f04fd35cf3e31033e99b79c622
Cr-Commit-Position: refs/heads/master@{#35285}

Powered by Google App Engine
This is Rietveld 408576698