Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1862753002: cubic stroke fix (Closed)

Created:
4 years, 8 months ago by caryclark
Modified:
4 years, 8 months ago
Reviewers:
herb_g, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

cubic stroke fix Normally parallel tangents means that the stroke can be represented with a line. But looping cubics can have parallel tangents if the loop is 180 degrees. Check to see if the tangents direction is opposite to subdivide further. R=reed@google.com BUG=skia:5099 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862753002 Committed: https://skia.googlesource.com/skia/+/4693a1748f19fa4ee83c6eee2333b39ffb3febd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M gm/cubicpaths.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M src/core/SkStroke.cpp View 4 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862753002/1
4 years, 8 months ago (2016-04-05 21:02:05 UTC) #3
caryclark
4 years, 8 months ago (2016-04-05 21:02:42 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/7598) Build-Mac-Clang-x86_64-Release-Trybot on ...
4 years, 8 months ago (2016-04-05 21:03:38 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862753002/1
4 years, 8 months ago (2016-04-06 00:20:37 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 00:34:20 UTC) #10
caryclark
4 years, 8 months ago (2016-04-06 15:48:08 UTC) #13
herb_g
lgtm
4 years, 8 months ago (2016-04-06 15:52:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862753002/1
4 years, 8 months ago (2016-04-06 15:53:11 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 15:54:09 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4693a1748f19fa4ee83c6eee2333b39ffb3febd4

Powered by Google App Engine
This is Rietveld 408576698