third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp - Issue 1862733002: Remove all use of crop edges from SkImageFilter::CropRect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

Issue 1862733002: Remove all use of crop edges from SkImageFilter::CropRect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update to ToT Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

index 3f6e792e1b86dd178ff4a84bc5530984df8cc95d..fe74815e557ca3a4b9b4fd2bdc8e4b76474c6628 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

@@ -321,6 +321,9 @@ SkImageFilter* CanvasRenderingContext2DState::getFilter(Element* styleResolution

SkiaImageFilterBuilder imageFilterBuilder;

FilterEffect* lastEffect = filterEffectBuilder->lastEffect();

+ if (lastEffect) {

+ lastEffect->determineFilterPrimitiveSubregion();

+ }

m_resolvedFilter = imageFilterBuilder.build(lastEffect, ColorSpaceDeviceRGB);

if (m_resolvedFilter) {

updateFilterReferences(toHTMLCanvasElement(styleResolutionHost), context, filterStyle->filter());