Chromium Code Reviews| Index: ui/shell_dialogs/gtk/select_file_dialog_impl_gtk.cc |
| diff --git a/ui/shell_dialogs/gtk/select_file_dialog_impl_gtk.cc b/ui/shell_dialogs/gtk/select_file_dialog_impl_gtk.cc |
| index 5bade75d3903f119ab42297e60426e8ffb7d2705..3046d9d6ac2787d689614235d9674fb993d528cb 100644 |
| --- a/ui/shell_dialogs/gtk/select_file_dialog_impl_gtk.cc |
| +++ b/ui/shell_dialogs/gtk/select_file_dialog_impl_gtk.cc |
| @@ -75,7 +75,8 @@ class SelectFileDialogImplGTK : public ui::SelectFileDialogImpl { |
| // us when we were told to show the dialog. |
| void FileNotSelected(GtkWidget* dialog); |
| - GtkWidget* CreateSelectFolderDialog(const std::string& title, |
| + GtkWidget* CreateSelectFolderDialog( |
| + Type type, const std::string& title, |
|
sky
2013/07/29 16:22:34
nit: when you wrap, one param per line.
kinuko
2013/07/30 07:37:16
Done.
|
| const base::FilePath& default_path, gfx::NativeWindow parent); |
| GtkWidget* CreateFileOpenDialog(const std::string& title, |
| @@ -191,7 +192,8 @@ void SelectFileDialogImplGTK::SelectFileImpl( |
| GtkWidget* dialog = NULL; |
| switch (type) { |
| case SELECT_FOLDER: |
| - dialog = CreateSelectFolderDialog(title_string, default_path, |
| + case SELECT_UPLOAD_FOLDER: |
| + dialog = CreateSelectFolderDialog(type, title_string, default_path, |
| owning_window); |
| break; |
| case SELECT_OPEN_FILE: |
| @@ -351,17 +353,26 @@ GtkWidget* SelectFileDialogImplGTK::CreateFileOpenHelper( |
| } |
| GtkWidget* SelectFileDialogImplGTK::CreateSelectFolderDialog( |
| + Type type, |
| const std::string& title, |
| const base::FilePath& default_path, |
| gfx::NativeWindow parent) { |
| - std::string title_string = !title.empty() ? title : |
| + std::string title_string = title; |
| + if (title_string.empty()) { |
| + title_string = (type == SELECT_UPLOAD_FOLDER) ? |
| + l10n_util::GetStringUTF8(IDS_SELECT_UPLOAD_FOLDER_DIALOG_TITLE) : |
| l10n_util::GetStringUTF8(IDS_SELECT_FOLDER_DIALOG_TITLE); |
| + } |
| + std::string accept_button_label = (type == SELECT_UPLOAD_FOLDER) ? |
| + l10n_util::GetStringUTF8(IDS_SELECT_UPLOAD_FOLDER_DIALOG_UPLOAD_BUTTON) : |
| + GTK_STOCK_OPEN; |
| GtkWidget* dialog = |
| gtk_file_chooser_dialog_new(title_string.c_str(), parent, |
| GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER, |
| GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL, |
| - GTK_STOCK_OPEN, GTK_RESPONSE_ACCEPT, |
| + accept_button_label.c_str(), |
| + GTK_RESPONSE_ACCEPT, |
| NULL); |
| if (!default_path.empty()) { |