Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 18627002: Change dialog texts for folder upload to explicitly indicate it's for 'Uploading' (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/js/file_manager.js
diff --git a/chrome/browser/resources/file_manager/js/file_manager.js b/chrome/browser/resources/file_manager/js/file_manager.js
index 22810e56831c206d0a22869a7a6aea456d71c802..484fbe35398aba3cd78f7f5460c71edfb907fc6c 100644
--- a/chrome/browser/resources/file_manager/js/file_manager.js
+++ b/chrome/browser/resources/file_manager/js/file_manager.js
@@ -62,6 +62,7 @@ function unload() {
*/
var DialogType = {
SELECT_FOLDER: 'folder',
+ SELECT_UPLOAD_FOLDER: 'upload-folder',
SELECT_SAVEAS_FILE: 'saveas-file',
SELECT_OPEN_FILE: 'open-file',
SELECT_OPEN_MULTI_FILE: 'open-multi-file',
@@ -118,6 +119,7 @@ TextMeasure.prototype.getWidth = function(text) {
*/
DialogType.isModal = function(type) {
return type == DialogType.SELECT_FOLDER ||
+ type == DialogType.SELECT_UPLOAD_FOLDER ||
type == DialogType.SELECT_SAVEAS_FILE ||
type == DialogType.SELECT_OPEN_FILE ||
type == DialogType.SELECT_OPEN_MULTI_FILE;
@@ -839,6 +841,7 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52;
this.fileTypes_ = this.params_.typeList || [];
metrics.recordEnum('Create', this.dialogType,
[DialogType.SELECT_FOLDER,
+ DialogType.SELECT_UPLOAD_FOLDER,
DialogType.SELECT_SAVEAS_FILE,
DialogType.SELECT_OPEN_FILE,
DialogType.SELECT_OPEN_MULTI_FILE,
@@ -1116,6 +1119,7 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52;
var singleSelection =
this.dialogType == DialogType.SELECT_OPEN_FILE ||
this.dialogType == DialogType.SELECT_FOLDER ||
+ this.dialogType == DialogType.SELECT_UPLOAD_FOLDER ||
this.dialogType == DialogType.SELECT_SAVEAS_FILE;
var showSpecialSearchRoots =
@@ -1764,6 +1768,11 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52;
defaultTitle = str('SELECT_FOLDER_TITLE');
break;
+ case DialogType.SELECT_UPLOAD_FOLDER:
+ defaultTitle = str('SELECT_UPLOAD_FOLDER_TITLE');
+ okLabel = str('UPLOAD_LABEL');
+ break;
+
case DialogType.SELECT_OPEN_FILE:
defaultTitle = str('SELECT_OPEN_FILE_TITLE');
break;
@@ -2936,7 +2945,8 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52;
var selection = this.getSelection();
if (selection.totalCount == 1 &&
selection.entries[0].isDirectory &&
- this.dialogType != DialogType.SELECT_FOLDER) {
+ this.dialogType != DialogType.SELECT_FOLDER &&
+ this.dialogType != DialogType.SELECT_UPLOAD_FOLDER) {
event.preventDefault();
this.onDirectoryAction(selection.entries[0]);
} else if (this.dispatchSelectionAction_()) {
@@ -3255,7 +3265,8 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52;
var files = [];
var selectedIndexes = this.currentList_.selectionModel.selectedIndexes;
- if (this.dialogType == DialogType.SELECT_FOLDER &&
+ if ((this.dialogType == DialogType.SELECT_FOLDER ||
+ this.dialogType == DialogType.SELECT_UPLOAD_FOLDER) &&
selectedIndexes.length == 0) {
var url = this.getCurrentDirectoryURL();
var singleSelection = {
@@ -3300,7 +3311,8 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52;
var selectedEntry = dm.item(selectedIndexes[0]);
- if (this.dialogType == DialogType.SELECT_FOLDER) {
+ if (this.dialogType == DialogType.SELECT_FOLDER ||
+ this.dialogType == DialogType.SELECT_UPLOAD_FOLDER) {
if (!selectedEntry.isDirectory)
throw new Error('Selected entry is not a folder!');
} else if (this.dialogType == DialogType.SELECT_OPEN_FILE) {

Powered by Google App Engine
This is Rietveld 408576698