content/renderer/pepper/pepper_plugin_instance_impl.h - Issue 1862693002: Replace skia::RefPtr with sk_sp<> in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.h

Issue 1862693002: Replace skia::RefPtr with sk_sp<> in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unget Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/pepper_plugin_instance_impl.h

diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.h b/content/renderer/pepper/pepper_plugin_instance_impl.h

index c02a4505452d7616c1296f5b8d9618d5cd4eab91..db95d8e6c1bbc8840a66c1f3a2d3a6bfed5c6934 100644

--- a/content/renderer/pepper/pepper_plugin_instance_impl.h

+++ b/content/renderer/pepper/pepper_plugin_instance_impl.h

@@ -54,7 +54,6 @@

#include "ppapi/shared_impl/tracked_callback.h"

#include "ppapi/thunk/ppb_gamepad_api.h"

#include "ppapi/thunk/resource_creation_api.h"

-#include "skia/ext/refptr.h"

#include "third_party/WebKit/public/platform/WebCanvas.h"

#include "third_party/WebKit/public/platform/WebString.h"

#include "third_party/WebKit/public/platform/WebURLLoaderClient.h"

@@ -807,7 +806,7 @@ class CONTENT_EXPORT PepperPluginInstanceImpl

// to generate the entire PDF given the variables below:

// The most recently used WebCanvas, guaranteed to be valid.

- skia::RefPtr<blink::WebCanvas> canvas_;

+ sk_sp<blink::WebCanvas> canvas_;

// An array of page ranges.

std::vector<PP_PrintPageNumberRange_Dev> ranges_;