Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1862693002: Replace skia::RefPtr with sk_sp<> in content/ (Closed)

Created:
4 years, 8 months ago by tomhudson
Modified:
4 years, 8 months ago
Reviewers:
Mike West, f(malita), piman
CC:
avayvod+watch_chromium.org, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, sievers+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace skia::RefPtr with sk_sp<> in content/ Incremental progress towards getting rid of the skia::RefPtr adapter class. BUG=skia:5077 Committed: https://crrev.com/73faaed933b8697520547741d4483d1f05a1c4fb Cr-Commit-Position: refs/heads/master@{#385732}

Patch Set 1 #

Patch Set 2 : fix mac build, investigate use-after-free #

Patch Set 3 : share context instead of adopting it #

Patch Set 4 : rebase #

Total comments: 5

Patch Set 5 : reviews #

Total comments: 2

Patch Set 6 : unget #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -30 lines) Patch
M content/browser/compositor/software_output_device_mac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/surface_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_ipc_browsertests.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/common/cc_messages.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/common/gpu/client/grcontext_for_gles2_interface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/client/grcontext_for_gles2_interface.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/media/canvas_capture_handler_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/media/html_video_element_capturer_source.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/html_video_element_capturer_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/ppb_image_data_impl.h View 3 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/pepper/ppb_image_data_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 33 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862693002/1
4 years, 8 months ago (2016-04-05 17:02:59 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/183022) mac_chromium_rel_ng on ...
4 years, 8 months ago (2016-04-05 17:19:43 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862693002/20001
4 years, 8 months ago (2016-04-05 17:49:56 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/139842)
4 years, 8 months ago (2016-04-05 18:16:58 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862693002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862693002/40001
4 years, 8 months ago (2016-04-06 14:48:52 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 15:44:58 UTC) #12
tomhudson
mkwst@: please security-review content/common/cc_messages.cc piman@: please review content/ (If I understand owners correctly, you can ...
4 years, 8 months ago (2016-04-06 18:08:15 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862693002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862693002/60001
4 years, 8 months ago (2016-04-06 18:10:00 UTC) #16
piman
https://codereview.chromium.org/1862693002/diff/60001/content/renderer/pepper/pepper_plugin_instance_impl.cc File content/renderer/pepper/pepper_plugin_instance_impl.cc (right): https://codereview.chromium.org/1862693002/diff/60001/content/renderer/pepper/pepper_plugin_instance_impl.cc#newcode1770 content/renderer/pepper/pepper_plugin_instance_impl.cc:1770: canvas_ = sk_sp<SkCanvas>(canvas); Shouldn't this be sk_ref_sp?
4 years, 8 months ago (2016-04-06 18:23:29 UTC) #17
f(malita)
https://codereview.chromium.org/1862693002/diff/60001/content/common/gpu/client/grcontext_for_gles2_interface.cc File content/common/gpu/client/grcontext_for_gles2_interface.cc (right): https://codereview.chromium.org/1862693002/diff/60001/content/common/gpu/client/grcontext_for_gles2_interface.cc#newcode24 content/common/gpu/client/grcontext_for_gles2_interface.cc:24: skia_bindings::CreateGLES2InterfaceBindings(gl).get()); This looks odd - is there anything wrong ...
4 years, 8 months ago (2016-04-06 18:37:21 UTC) #18
tomhudson
https://codereview.chromium.org/1862693002/diff/60001/content/common/gpu/client/grcontext_for_gles2_interface.cc File content/common/gpu/client/grcontext_for_gles2_interface.cc (right): https://codereview.chromium.org/1862693002/diff/60001/content/common/gpu/client/grcontext_for_gles2_interface.cc#newcode24 content/common/gpu/client/grcontext_for_gles2_interface.cc:24: skia_bindings::CreateGLES2InterfaceBindings(gl).get()); On 2016/04/06 18:37:21, f(malita) wrote: > This looks ...
4 years, 8 months ago (2016-04-06 19:00:23 UTC) #19
f(malita)
https://codereview.chromium.org/1862693002/diff/80001/content/common/gpu/client/grcontext_for_gles2_interface.cc File content/common/gpu/client/grcontext_for_gles2_interface.cc (right): https://codereview.chromium.org/1862693002/diff/80001/content/common/gpu/client/grcontext_for_gles2_interface.cc#newcode24 content/common/gpu/client/grcontext_for_gles2_interface.cc:24: skia_bindings::CreateGLES2InterfaceBindings(gl).get()); Extra get() prolly causing trouble here (adoption of ...
4 years, 8 months ago (2016-04-06 19:03:34 UTC) #20
tomhudson
https://codereview.chromium.org/1862693002/diff/80001/content/common/gpu/client/grcontext_for_gles2_interface.cc File content/common/gpu/client/grcontext_for_gles2_interface.cc (right): https://codereview.chromium.org/1862693002/diff/80001/content/common/gpu/client/grcontext_for_gles2_interface.cc#newcode24 content/common/gpu/client/grcontext_for_gles2_interface.cc:24: skia_bindings::CreateGLES2InterfaceBindings(gl).get()); On 2016/04/06 19:03:34, f(malita) wrote: > Extra get() ...
4 years, 8 months ago (2016-04-06 19:30:24 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862693002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862693002/100001
4 years, 8 months ago (2016-04-06 19:31:09 UTC) #23
piman
lgtm
4 years, 8 months ago (2016-04-06 19:34:13 UTC) #24
f(malita)
lgtm
4 years, 8 months ago (2016-04-06 19:37:58 UTC) #25
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/200776)
4 years, 8 months ago (2016-04-06 22:11:07 UTC) #27
Mike West
IPC LGTM.
4 years, 8 months ago (2016-04-07 08:38:35 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862693002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862693002/100001
4 years, 8 months ago (2016-04-07 12:26:03 UTC) #30
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-04-07 13:12:46 UTC) #31
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 13:14:33 UTC) #33
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/73faaed933b8697520547741d4483d1f05a1c4fb
Cr-Commit-Position: refs/heads/master@{#385732}

Powered by Google App Engine
This is Rietveld 408576698